Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #462

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #462

wants to merge 6 commits into from

Conversation

kapesha
Copy link

@kapesha kapesha commented Nov 6, 2024

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 6, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add correct address for these links and open it in the new tab
image image

anastasiiavorobiova
anastasiiavorobiova suggested changes Nov 6, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-11-06 at 16 13 02
  • The scroll under the menu should be removed
  • Screenshot 2024-11-06 at 16 12 22
  • The whole section jumps on the hover. Consider fixing it
  • Screenshot 2024-11-06 at 16 12 15
  • Check paddings for the header
  • Screenshot 2024-11-06 at 16 12 08
  • Links shouldn't lead to the 404 page. Consider using index.html href for the logo link and href='#' for other links

anastasiiavorobiova
anastasiiavorobiova suggested changes Nov 7, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Almost done
Screenshot 2024-11-07 at 17 26 06

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Nov 8, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapesha @VitaliyBondarenko1982 @volodymyr-soltys97 @anastasiiavorobiova