Skip to content

Conversation

matdev83
Copy link
Owner

@matdev83 matdev83 commented Oct 9, 2025

Summary

  • ensure the redact_dict test checks that API keys are actually masked

Testing

  • not run (not requested)

https://chatgpt.com/codex/tasks/task_e_68e7cf14aa408333afaee14057a21d8a

@matdev83
Copy link
Owner Author

Review Summary

❌ BLOCKED - Pre-existing test failures must be resolved

Analysis

This PR makes a minimal, safe improvement to the test validation in :

  • Changes hardcoded assertion to reference actual test data
  • Adds validation that redacted values contain masking pattern
  • The change itself is correct and improves test robustness

Blocking Issues

However, there are 2 pre-existing test failures in the request processor integration tests:

These failures are caused by changes to the redaction middleware where the command prefix was changed from !/ to /, but tests weren't updated accordingly. These failures exist on the dev branch and are unrelated to this PR.

Required Changes

Before this PR can be merged, the following must be resolved:

  1. Fix the failing request processor tests to work with the new redaction middleware
  2. Ensure all tests pass on the dev branch

The PR itself is ready to merge once the test infrastructure issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant