Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Color of the hovered home button text" definition broken? #471

Open
r4dh4l opened this issue Nov 28, 2020 · 2 comments
Open

"Color of the hovered home button text" definition broken? #471

r4dh4l opened this issue Nov 28, 2020 · 2 comments

Comments

@r4dh4l
Copy link

r4dh4l commented Nov 28, 2020

Hi,

the option --MENU-HOME-LINK-HOVER-color: #...; /* Color of the hovered home button text */ in the theme definition (example: theme-blue.css) seems not to work. The hovered color is "white" regardless which colour you define. Is there a way to fix this? Currently it "breaks" the home button for custom themes with "#ffffff" (white) for --MENU-HEADER-BORDER-color: ....

However: Thx for the great theme!

@mirisbowring
Copy link
Contributor

Hi @r4dh4l ,

I found the problem:

color: var(--MENU-HOME-LINK-HOVERED-color);

This line links to --MENU-HOME-LINK-HOVERED-color but the variable defined in :root is --MENU-HOME-LINK-HOVER-color:.

So, as a first fix, you could either remove the D from line 127 or add a Dto line 11.

Since i've implemented this feature, i will make a PR to fix this bug.

Thank you!

@r4dh4l
Copy link
Author

r4dh4l commented Nov 28, 2020

So, as a first fix, you could either remove the D from line 127 or add a Dto line 11.

Great, thank you so much!

maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
as long as the colors aren't configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants