[RFC] add feasibility checker #12
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 87.34% 79.93% -7.42%
==========================================
Files 5 5
Lines 332 294 -38
==========================================
- Hits 290 235 -55
- Misses 42 59 +17
Continue to review full report at Codecov.
|
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
|
|
||
| largest, vec = constraint_violation(model, varval = varval, distance_map = distance_map) | ||
|
|
||
| str = " Feasibility report\n\n" |
There was a problem hiding this comment.
maybe these using a multiline string:
s = """Feasibility report
...
"""
There was a problem hiding this comment.
Agree! I will be back soon to it
|
Maybe adding docstrings on the functions to see what they are meant to be used for / be doing |
| @@ -0,0 +1,110 @@ | |||
| const MOD = MathOptSetDistances | |||
There was a problem hiding this comment.
Is the module name needed here?
|
re-opening PR to run on actions |
Co-authored-by: Mathieu Besançon <mathieu.besancon@gmail.com>
|
I'm not sure about this conflict resolution, feel free to revert if it caused more damage than good |
|
ok definitely broke something 😬 |
|
I am writing version 2.0. |
|
so... |
This might end up in a separate package.
It is a possible solution for jump-dev/JuMP.jl#693