Add support for Unsubscribe-URL
#8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l never be working again (invalid tokens) See mastodon/mastodon#32626 for the PR implementing this in Mastodon
ThisIsMissEm
reviewed
Nov 4, 2024
timbray
reviewed
Nov 4, 2024
| isProduction bool | ||
| notification *apns2.Notification | ||
| unsubscribeUrl string | ||
| requestLog *log.Entry // For logging with datadog context |
There was a problem hiding this comment.
A little gross to have support for specific commercial non-OSS products wired into the code? Would this log.Entry usable with a DataDog competitor?
There was a problem hiding this comment.
Logrus provides means to write custom hooks for any need you may have, so yes it would be usable.
A lot of third party hooks already exist, some of which are listed here.
| messageChan <- &Message{isProduction, notification, requestLog} | ||
| unsubscribeUrl := request.Header.Get("Unsubscribe-Url") | ||
|
|
||
| messageChan <- &Message{isProduction, notification, unsubscribeUrl, requestLog} |
There was a problem hiding this comment.
If there's no Unsubscribe-url header you' send "" along in unsubscribeUrl, that OK?
There was a problem hiding this comment.
The if statement at line 81 ensures that the behavior is unchanged in this case. The new unsubscribed field in the entry does not cause issues elsewhere if not read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
Unsubscribe-URLheader to unregister subscriptions that will never be working again (invalid tokens)See mastodon/mastodon#32626 for the PR implementing this in Mastodon