Change design of embed modal in web UI #31801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
feature-embed-modal-redesign
branch
4 times, most recently
from
e6c6f26
to
dbbc7c0
Compare
Gargron
force-pushed
the
feature-embed-modal-redesign
branch
from
dbbc7c0
to
4efc82f
Compare
Gargron
force-pushed
the
feature-embed-status-react
branch
from
1282353
to
cb07e1b
Compare
Gargron
force-pushed
the
feature-embed-modal-redesign
branch
from
4efc82f
to
a834895
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
ClearlyClaire
force-pushed
the
feature-embed-modal-redesign
branch
from
a834895
to
79a3492
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
ClearlyClaire
force-pushed
the
feature-embed-modal-redesign
branch
from
79a3492
to
e915037
Compare
ClearlyClaire
approved these changes
Sep 12, 2024
|
This pull request has resolved merge conflicts and is ready for review. |
renchap
approved these changes
Sep 12, 2024
oneiros
approved these changes
Sep 12, 2024
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
nileane
pushed a commit
to nileane/mastodon
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So! This is an updated embed modal, based on new modal designs. It comes with a much better looking and more functional copy-paste component, and renders the embed previews with the correct height for the first time. Oh, and I'm switching embeds to always be light mode. Since most blogs/magazines have a light background.
There is a varied degree of cursed things I had to do to make this work:
httpto theframe-srcCSP directiveTo make inline styles on the embed codes work in the previews, I had to add sha256 hashes of every inline style I used to CSP