Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LinkCrawlWorker error when encountering empty OEmbed response #28268

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Dec 7, 2023

Fixes #28233

@ClearlyClaire ClearlyClaire added the bug Something isn't working label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f3864db) 83.47% compared to head (303d8e8) 83.47%.
Report is 2 commits behind head on main.

Files Patch % Lines
app/services/fetch_oembed_service.rb 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28268   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files        1038     1038           
  Lines       28230    28230           
  Branches     4554     4554           
=======================================
  Hits        23565    23565           
  Misses       3536     3536           
  Partials     1129     1129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire requested a review from a team December 8, 2023 09:27
@Gargron Gargron added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit a8a5c65 Dec 12, 2023
55 checks passed
@Gargron Gargron deleted the fixes/empty-oembed branch December 12, 2023 08:35
@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Dec 14, 2023
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Dec 14, 2023
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Jan 5, 2024
This was referenced Jan 23, 2024
noellabo pushed a commit to fedibird/mastodon that referenced this pull request Jan 24, 2024
@stevek101
Copy link

Since installing 4.2.4, the IndexingScheduler is running nonstop (4-7 Scheduler::IndexingScheduler jobs running). This is maxxing the CPU. Could this be related to the LinkCrawlWorker changes?

@ClearlyClaire
Copy link
Contributor Author

No, that does not seem related at all. Can you open an issue for this, with information on your Elasticsearch deployment, whether you updated from 4.2.3 or from an older release, what size your instance is and whether you have had a recent increase in traffic?

ttrace pushed a commit to ttrace/mastodon that referenced this pull request Feb 2, 2024
@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label May 10, 2024
Isaw-w pushed a commit to Isaw-w/mastodon that referenced this pull request Aug 28, 2024
noellabo pushed a commit to fedibird/mastodon that referenced this pull request Sep 9, 2024
noellabo pushed a commit to fedibird/mastodon that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkCrawlWorker throws a NoMethodError [] for nilClass because Link Oembed json resolves to "null"
5 participants