Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination of followed tags #20861

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix pagination of followed tags #20861

merged 2 commits into from
Nov 17, 2022

Conversation

trwnh
Copy link
Member

@trwnh trwnh commented Nov 16, 2022

No description provided.

@trwnh trwnh changed the title Fix missing pagination headers on followed tags Fix pagination of followed tags Nov 16, 2022
@ineffyble ineffyble added bug Something isn't working api REST API, Streaming API, Web Push API labels Nov 16, 2022
casaper
casaper approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@casaper casaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like TAG_LIMIT was a typo. The TAGS_LIMIT constant was last touched with the same commit at least.
And the controller has no show action nor does it inherit one AFAIS.
Looks good to me.

@Gargron Gargron merged commit e1f819f into mastodon:main Nov 17, 2022
@trwnh trwnh deleted the patch-6 branch November 18, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casaper casaper casaper approved these changes

@ineffyble ineffyble ineffyble approved these changes

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
api REST API, Streaming API, Web Push API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trwnh @ClearlyClaire @ineffyble @casaper @Gargron