Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old unique jobs digests not having been cleaned up #13683

Merged
merged 1 commit into from
May 9, 2020

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented May 8, 2020

No description provided.

@Gargron Gargron merged commit 38b6951 into master May 9, 2020
@ykzts ykzts deleted the fix-reset-unique-jobs-digests branch May 9, 2020 16:42
@ClearlyClaire
Copy link
Contributor

Shouldn't this be a post-deployment migration?

@Gargron
Copy link
Member Author

Gargron commented May 10, 2020

It will probably not be possible for problematic locks to be created in the time it takes to upgrade. I can see your point and ideally I guess it should've been a post-deployment migration but since the actual fix was already released before, most people upgrading will have been running fixed code before this migration anyway. Hm.

@ClearlyClaire
Copy link
Contributor

Hm… we could still merge it, would avoid potential issues for people “skipping releases” (which I don't think should be discouraged—apart from the fact that not updating should be discouraged I mean—and is sometimes required since some releases can't be installed anymore, and that may happen to more releases down the road).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants