Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-271: Fix translate functionality leads to empty status content #1320

Merged
merged 10 commits into from
Jun 26, 2024
Merged

IOS-271: Fix translate functionality leads to empty status content #1320

merged 10 commits into from
Jun 26, 2024

Conversation

kimar
Copy link
Contributor

@kimar kimar commented Jun 25, 2024 •
edited
Loading

This PR solves the following things:

  1. Fixes the post body being set to an empty string in case translation fails
  2. Fetches /api/v1/instance/translation_languages (only if the /api/v2/instance is available) and checks if the transaction between the desired languages is possible
  3. Refactors Instance usage to now use MastodonAuthentication.InstanceConfiguration if feasible with low effort
  4. On the home timeline, the reblog status (the wrapper) is taken into account for translation which leads to the translation failing

@kimar kimar self-assigned this Jun 25, 2024
@kimar kimar changed the title [WIP] IOS-271: Fix translate functionality leads to empty status content IOS-271: Fix translate functionality leads to empty status content Jun 25, 2024
@kimar kimar marked this pull request as ready for review June 25, 2024 09:37
@kimar kimar requested a review from zeitschlag June 25, 2024 09:37
zeitschlag
zeitschlag approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick testrun was successful, translation works, code looks good.

Good work, thank you! 👍

MastodonSDK/Sources/MastodonCore/MastodonAuthentication.swift Outdated Show resolved Hide resolved
MastodonSDK/Sources/MastodonCore/Service/InstanceService.swift Outdated Show resolved Hide resolved
@zeitschlag zeitschlag added this to the 2024.7 milestone Jun 26, 2024
@kimar kimar merged commit 1a8fbe7 into develop Jun 26, 2024
2 checks passed
@kimar kimar deleted the IOS-271_Fix_Translation_Not_Working branch June 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitschlag zeitschlag zeitschlag approved these changes

Assignees

@kimar kimar

Labels
None yet
Projects
None yet
Milestone
2024.7
Development

Successfully merging this pull request may close these issues.
2 participants
@kimar @zeitschlag