Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React/DP-13800: Deprecated lifecycle methods #566

Merged
merged 6 commits into from
Jun 6, 2019
Merged

React/DP-13800: Deprecated lifecycle methods #566

merged 6 commits into from
Jun 6, 2019

Conversation

smurrayatwork
Copy link
Contributor

Description

  • (React) [InputTextFuzzy] DP-13800: Adds prop onKeyDownPreventDefault. When set to true, hitting enter without a valid suggestion will trigger event.preventDefault().

Related Issue / Ticket

Steps to Test

  1. Pull the branch and ensure all automated tests pass and InputTextFuzzy has no visual changes in functionality.

@clairesunstudio
Copy link
Contributor

Can you in this pr, switching InputTextTypeAhead with InputTextFuzzy for pressfilter in filterbox/SearchBanner? so we don't need to npm link to search to test the form submission

@clairesunstudio
Copy link
Contributor

clairesunstudio commented May 31, 2019 •
edited
Loading

filter-clear

In search, currently this is preventing empty value from inputTextFuzzy to be submitted.
The expected behavior is that when the inputTextFuzzy value is empty and user hit enter, the filterBox form will submit it as an empty value. If a filter tag of that field already exist, it will remove that filter tag.

clairesunstudio
clairesunstudio approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@clairesunstudio clairesunstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with https://github.com/massgov/massgov-search/pull/353 and works as expected.

@clairesunstudio clairesunstudio merged commit c4a56e7 into develop Jun 6, 2019
@clairesunstudio clairesunstudio deleted the react/DP-13800--deprecated-lifecycle-methods branch June 6, 2019 19:35
This was referenced Jun 7, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairesunstudio clairesunstudio clairesunstudio approved these changes

@avrilpearl avrilpearl avrilpearl approved these changes

Assignees
No one assigned
Labels
external review React
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smurrayatwork @clairesunstudio @avrilpearl