Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-13967 Fix the display of heading size for Related Service/Additional Resources on service page #563

Merged
merged 2 commits into from
May 24, 2019

Conversation

mrossi113
Copy link
Contributor

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

@clair0917 fixed this issue I'm just creating a PR for it. When inspecting the service page https://mayflower.digital.mass.gov/?p=pages-service particularly the Additional Resources/Related Services these headings were showing an h2 when they were supposed to be showing h3.

Related Issue / Ticket

Steps to Test

  1. Compare https://mayflower.digital.mass.gov/?p=pages-service to http://localhost:3000/?p=pages-service.
  2. Inspect the Related Services and Additional Resources under the More Information section
  3. Both sections Related Services and Additional Resources should have h3 not h2 listed.

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Changes to the heading:
Screen Shot 2019-05-21 at 2 05 46 PM

The current display in Mayflower:
Screen Shot 2019-05-21 at 2 22 23 PM

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

Copy link
Contributor

@ygannett ygannett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ygannett ygannett merged commit 02b571c into develop May 24, 2019
@avrilpearl avrilpearl deleted the patternlab/DP-13967-fix-heading-related-additional branch June 27, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants