Patternlab/dp 14006 update manage your account #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygannett
requested changes
May 22, 2019
patternlab/styleguide/source/_patterns/03-organisms/by-author/account-manager.twig
Outdated
Show resolved
Hide resolved
Updated new descriptive-links-wrapper to ensure link data is passed on to new descriptive-link molecule.
|
We've updated the patterns available here to make them a bit more abstract so they could be used in more than one place. @clair0917 rightly noted that a "descriptive link" template would be valuable in the system. I provided a small update to how link data is passed through to the new "descriptive link" molecule which should resolve issues with json demo data note loading. |
Merged
avrilpearl
deleted the
patternlab/DP-14006--update-manage-your-account-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update "Manage your account" stickyNav id
Related Issue / Ticket
Steps to Test
https://mayflower.digital.mass.gov/b/patternlab/DP-14006--update-manage-your-account-id/patterns/03-organisms-by-author-account-manager/03-organisms-by-author-account-manager.html
Screenshots
Note:
This PR fixes a sticky nav issue encountered while Melissa was working on DP-10836