Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/ Refactor Illustrated Header and Page Header for semantic markup #560

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

clairesunstudio
Copy link
Contributor

@clairesunstudio clairesunstudio commented May 16, 2019

In React and Patternlab, Illustrated Header was rendering duplicated category and publishState fields that are now removed/replaced by the same fields in PageHeader inside of IllustratedHeader. This will fix the ordering issue seen in tnc report, allow the category to be visible for screen readers and print style
Screen Shot 2019-05-24 at 2 46 15 PM

The markup of PageHeader has category text repeated in two different tag, one is for SR only and one is for SR hidden. Now they are combined into one.
Before:

  <div class="ma__illustrated-header__content">
    <div class="ma__illustrated-header__category" aria-hidden="true">
      Guide
    </div>

    <section class="ma__page-header">
      <div class="ma__page-header__content">
        <h1 class="ma__page-header__title">
          <span class="visually-hidden">Guide&nbsp;</span>
          Moving to Massachusetts
        </h1>
...

Same fix is also ported into patternlab.

@clairesunstudio clairesunstudio changed the title react/ add prop to allow aria-hidden category text to be optional react/ add prop to allow Illustrated Header category fro SR and print May 16, 2019
@clairesunstudio clairesunstudio changed the title react/ add prop to allow Illustrated Header category fro SR and print react/ add prop to allow Illustrated Header category for SR and print May 16, 2019
@clairesunstudio clairesunstudio changed the title react/ add prop to allow Illustrated Header category for SR and print react/ Refactor Illustrated Header and Page Header for semantic markup May 28, 2019
@clairesunstudio
Copy link
Contributor Author

Based on the failed VR tests in patternlab, the only unexpected change is with the use of the Sub Category filed in PageHeader. Sub Category is not rendered in the markup in the same order as the markup visible to SR in <h1>. This field is only rendered in binder internal template and after reviewing all the court rule (binder internal) pages with the design team, and noticing mostly repetitive/misplaced information in the sub-category or subHeading field in the CMS. The design team decide to take out that field from Mayflower and from the CMS, but need to communicate/discuss about this change with Courts first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants