-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react/ Refactor Illustrated Header and Page Header for semantic markup #560
base: develop
Are you sure you want to change the base?
react/ Refactor Illustrated Header and Page Header for semantic markup #560
Conversation
Based on the failed VR tests in patternlab, the only unexpected change is with the use of the Sub Category filed in PageHeader. Sub Category is not rendered in the markup in the same order as the markup visible to SR in |
In React and Patternlab, Illustrated Header was rendering duplicated category and publishState fields that are now removed/replaced by the same fields in PageHeader inside of IllustratedHeader. This will fix the ordering issue seen in tnc report, allow the category to be visible for screen readers and print style
The markup of PageHeader has category text repeated in two different tag, one is for SR only and one is for SR hidden. Now they are combined into one.
Before:
Same fix is also ported into patternlab.