React/input currency pass event to callback #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr added parameter event type (and direction if any) to the InputCurrency onChange prop: |
avrilpearl
reviewed
Mar 4, 2019
avrilpearl
reviewed
Mar 4, 2019
avrilpearl
reviewed
Mar 4, 2019
avrilpearl
reviewed
Mar 4, 2019
avrilpearl
approved these changes
Mar 5, 2019
avrilpearl
reviewed
Mar 5, 2019
| const { showError, errorMsg } = validNumber(newValue, props.min, props.max); | ||
| context.updateState({ showError, errorMsg, value: toCurrency(newValue, 2) }, () => { | ||
| if (typeof props.onChange === 'function') { | ||
| props.onChange(newValue, props.id); | ||
| props.onChange(newValue, props.id, type); |
There was a problem hiding this comment.
Suggested change
| props.onChange(newValue, props.id, type); | |
| props.onChange(newValue, props.id, type, key); |
clairesunstudio
commented
Mar 5, 2019
smurrayatwork
approved these changes
Mar 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allow passing events to the onChange callout function, so that it can differentiate how the value is getting changed, get the type of events applied to InputCurrency.
It also fixes up/down button NaN value when default is null
This pr is to fix the bug in PFML Benefits Calculator:
npm linkto calculator pr