New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handle percent in utils #446

Merged

Thykof merged 1 commit into main from add-handle-percentage

May 23, 2024

Contributor

pivilartisant commented May 23, 2024

No description provided.


          add handle percent

080c527

pivilartisant changed the title ~~add handle percent~~ add handle percent in utils

pivilartisant linked an issue

that may be closed by this pull request

Include a lib to connect wallets #428

Closed

10 tasks

Contributor Author

pivilartisant commented May 23, 2024 •

edited

Loading

I initially wanted to modify the Money component, to directly handle the amount percentage to avoid code repetition in bridge and station but....

It should be noted that we handle percentage differently across bridge and station wallet.... looking at bridge i'm not convinced that the two methods are compatible without a refacto:
https://github.com/massalabs/bridge-web/blob/162301dbf0575441c948f3dd85f6ed8886d05dcf/src/pages/IndexPage/Layouts/BridgeRedeemLayout/BridgeRedeemLayout.tsx#L54-L76

Thykof approved these changes

View reviewed changes

Thykof merged commit 5b9d084 into main

7 checks passed

Thykof deleted the add-handle-percentage branch

May 23, 2024 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet