Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tonic to version 0.12.3 and jsonrpsee to 0.24 #4759

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Update tonic to version 0.12.3 and jsonrpsee to 0.24 #4759

merged 10 commits into from
Oct 8, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Oct 7, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds linked an issue Oct 7, 2024 that may be closed by this pull request
Update tonic to 0.12.3 #4755
Open
@sydhds sydhds requested review from Leo-Besancon and modship October 7, 2024 16:14
Leo-Besancon
Leo-Besancon reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that proto-rs needed an update too, from what I see it doesn't touch on the serialization of our structs, do you confirm? (that would mean it's not breaking and we don't need to have versioning, otherwise it's very tricky I think)

massa-sdk/src/lib.rs
.max_request_size(http_config.client_config.max_request_body_size)
.request_timeout(http_config.client_config.request_timeout.to_duration())
.max_concurrent_requests(http_config.client_config.max_concurrent_requests)
// .max_concurrent_requests(http_config.client_config.max_concurrent_requests)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't this config anymore? What's the impact?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the field max_concurrent_requests is now private (default is set to: 256). I'll make a PR for jsonrpsee and in the mean time will document this comment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks ! I'll keep this comment unresolved to avoid forgetting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to wait your PR to fix this before merge on main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paritytech/jsonrpsee#1470

modship
modship reviewed Oct 8, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
massa-sdk/src/lib.rs
.max_request_size(http_config.client_config.max_request_body_size)
.request_timeout(http_config.client_config.request_timeout.to_duration())
.max_concurrent_requests(http_config.client_config.max_concurrent_requests)
// .max_concurrent_requests(http_config.client_config.max_concurrent_requests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to wait your PR to fix this before merge on main

@sydhds sydhds merged commit 99ce8b7 into mainnet_2_3 Oct 8, 2024
11 checks passed
@sydhds sydhds deleted the feature/update_tonic_12_3_v2 branch October 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon left review comments

@modship modship modship left review comments

@bilboquet bilboquet bilboquet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tonic to 0.12.3
4 participants
@sydhds @bilboquet @modship @Leo-Besancon