Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update consensus GPI rule #4284

Merged
merged 4 commits into from
Jul 31, 2023
Merged

update consensus GPI rule #4284

merged 4 commits into from
Jul 31, 2023

Conversation

damip
Copy link
Member

@damip damip commented Jul 26, 2023 •
edited
Loading

Specification: Parallel_Incompatibility.pdf

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@damip damip changed the title update consensus rule update consensus GPI rule Jul 26, 2023
@damip damip marked this pull request as ready for review July 31, 2023 14:05
@damip damip requested a review from AurelienFT July 31, 2023 14:05
@damip
Copy link
Member Author

damip commented Jul 31, 2023 •
edited
Loading

@AurelienFT already reviewed by Leo and Seb

@damip damip merged commit 0cb927d into testnet_25 Jul 31, 2023
@AurelienFT AurelienFT deleted the update_consensus_gpi_rule branch October 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees

@Leo-Besancon Leo-Besancon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damip @AurelienFT @Leo-Besancon