Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ledger editor versioning 1 #4239

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Feature/ledger editor versioning 1 #4239

merged 11 commits into from
Jul 13, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jul 10, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds marked this pull request as draft July 10, 2023 12:47
@sydhds sydhds marked this pull request as ready for review July 13, 2023 09:25
@sydhds sydhds requested review from Leo-Besancon and Eitu33 July 13, 2023 09:25
Leo-Besancon
Leo-Besancon approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where, but can you update / produce some brief documentation about how the MIP_Store is handled for initialization (interactions with network restart / bootstrap / get_mip_list())?

@sydhds sydhds merged commit 9a1c2d0 into testnet_25 Jul 13, 2023
@sydhds sydhds deleted the feature/ledger_editor_versioning_1 branch July 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 approved these changes

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @Leo-Besancon @Eitu33