Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit test for Mip store update_with method #4208

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Add more unit test for Mip store update_with method #4208

merged 3 commits into from
Jul 5, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jul 4, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested a review from Leo-Besancon July 4, 2023 15:40
@sydhds sydhds linked an issue Jul 4, 2023 that may be closed by this pull request
Versioning: update_with bug? #4184
Closed
@sydhds sydhds force-pushed the feature/fully_unit_test_upgrade_with branch from 2816a8d to 0829746 Compare July 5, 2023 07:18
Leo-Besancon
Leo-Besancon approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and tests

massa-versioning/src/versioning.rs Show resolved Hide resolved
@sydhds sydhds merged commit be105ea into testnet_25 Jul 5, 2023
@sydhds sydhds deleted the feature/fully_unit_test_upgrade_with branch July 5, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioning: update_with bug?
2 participants
@sydhds @Leo-Besancon