Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code for get_keys SC abi #3243

Merged
merged 10 commits into from
Nov 30, 2022
Merged

Initial code for get_keys SC abi #3243

merged 10 commits into from
Nov 30, 2022

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Nov 24, 2022 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@damip
Copy link
Member

damip commented Nov 24, 2022

@sydhds FYI https://github.com/massalabs/massa/blob/main/massa-execution-worker/src/execution.rs#L1127

@sydhds sydhds force-pushed the feature/datastore_keys branch from 3cdffa0 to d477b39 Compare November 28, 2022 08:51
@sydhds
Copy link
Contributor Author

sydhds commented Nov 28, 2022

Associated PR:

@sydhds sydhds marked this pull request as ready for review November 28, 2022 10:55
AurelienFT
AurelienFT reviewed Nov 28, 2022
View reviewed changes
massa-execution-worker/Cargo.toml Outdated
@@ -21,7 +21,8 @@ massa_execution_exports = { path = "../massa-execution-exports" }
massa_models = { path = "../massa-models" }
massa_storage = { path = "../massa-storage" }
massa_hash = { path = "../massa-hash" }
massa-sc-runtime = { git = "https://github.com/massalabs/massa-sc-runtime", branch = "testnet_17" }
# massa-sc-runtime = { git = "https://github.com/massalabs/massa-sc-runtime", branch = "testnet_17" }
massa-sc-runtime = { path = "../../massa-sc-runtime" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge before changing this.
(This comment is to not forget)

damip
damip requested changes Nov 28, 2022
View reviewed changes
massa-execution-worker/src/speculative_ledger.rs Outdated Show resolved Hide resolved
massa-execution-worker/src/speculative_ledger.rs Outdated Show resolved Hide resolved
massa-ledger-exports/src/ledger_changes.rs Outdated Show resolved Hide resolved
massa-execution-worker/src/speculative_ledger.rs Show resolved Hide resolved
@sydhds sydhds requested a review from damip November 28, 2022 15:18
@sydhds sydhds requested a review from damip November 29, 2022 13:11
@sydhds sydhds requested a review from damip November 29, 2022 13:59
@AurelienFT
Copy link
Contributor

@sydhds the PR has been merged on runtime you can change back the path in dependencies

@sydhds sydhds force-pushed the feature/datastore_keys branch from f2d8f36 to 44568c1 Compare November 30, 2022 09:32
@sydhds sydhds merged commit d06b571 into testnet_17 Nov 30, 2022
@sydhds sydhds deleted the feature/datastore_keys branch November 30, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 left review comments

@aoudiamoncef aoudiamoncef aoudiamoncef left review comments

@AurelienFT AurelienFT AurelienFT approved these changes

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sydhds @damip @AurelienFT @aoudiamoncef @Eitu33