Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds binaries for Mac M1 #3213

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Adds binaries for Mac M1 #3213

merged 1 commit into from
Nov 10, 2022

Conversation

qdrn
Copy link
Contributor

@qdrn qdrn commented Nov 9, 2022

Closes #3212

@qdrn qdrn linked an issue Nov 9, 2022 that may be closed by this pull request
Add ARM64 binaries for MacOS #3212
Closed
@qdrn
Copy link
Contributor Author

qdrn commented Nov 9, 2022

Can you test the binaries generated for Mac M1 here @thomas-senechal https://github.com/qdrn/massa/releases/tag/TEST.13.0 and they work accept and merge this PR ?

@qdrn qdrn marked this pull request as ready for review November 9, 2022 21:04
@qdrn
Copy link
Contributor Author

qdrn commented Nov 9, 2022

Can also work with @Eitu33 :)

peterjah
peterjah approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@peterjah peterjah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Cross does not support aarch64-apple-darwin ( at least not like this) But the build should work because it will use cargo as fallback!

AurelienFT
AurelienFT approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with my M1

@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 10, 2022

Build succeeded:

@bors bors bot merged commit b008468 into main Nov 10, 2022
@qdrn qdrn deleted the 3212-add-arm64-binaries-for-macos branch November 10, 2022 23:03
@qdrn
Copy link
Contributor Author

qdrn commented Nov 10, 2022

FYI, Cross does not support aarch64-apple-darwin ( at least not like this) But the build should work because it will use cargo as fallback!

Thanks for the info. Maybe we can find something that is cleaner in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

@AurelienFT AurelienFT AurelienFT approved these changes

@Eitu33 Eitu33 Awaiting requested review from Eitu33

@thomas-senechal thomas-senechal Awaiting requested review from thomas-senechal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ARM64 binaries for MacOS
3 participants
@qdrn @AurelienFT @peterjah