Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a compilation error (maybe temporary) #2046

Closed
wants to merge 2 commits into from
Closed

Fix a compilation error (maybe temporary) #2046

wants to merge 2 commits into from

Conversation

adrien-zinger
Copy link
Contributor

It seems that we need to change something quick! The standard library will pass over

   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`

Opt for the fully qualified syntax

@adrien-zinger adrien-zinger added this to the TEST.6.0 milestone Dec 28, 2021
@adrien-zinger adrien-zinger self-assigned this Dec 28, 2021
@damip
Copy link
Member

damip commented Dec 28, 2021

As you prefer :) I would have voted for #![feature(int_roundings)] but there are pros and cons to both solutions

gterzian
gterzian previously approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

damip
damip previously approved these changes Dec 29, 2021
View reviewed changes
@adrien-zinger
Fix a compilation error (maybe temporary)
c898dc5 
It seems that we need to change something quick! The standard library will pass over

```bash
   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust#48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`
```

Opt for the fully qualified syntax
@adrien-zinger adrien-zinger dismissed stale reviews from damip and gterzian via c898dc5 December 29, 2021 11:41
@adrien-zinger
Copy link
Contributor Author

Bors merge

bors bot added a commit that referenced this pull request Dec 30, 2021
@bors @adrien-zinger
Merge #2046
e3e4e45 
2046: Fix a compilation error (maybe temporary) r=adrien-zinger a=adrien-zinger

It seems that we need to change something quick! The standard library will pass over

```bash
   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust#48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`
```

Opt for the fully qualified syntax

Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@damip
Copy link
Member

damip commented Dec 30, 2021

bors merge

bors bot added a commit that referenced this pull request Dec 30, 2021
@bors @adrien-zinger
Merge #2046
d6e5aaa 
2046: Fix a compilation error (maybe temporary) r=damip a=adrien-zinger

It seems that we need to change something quick! The standard library will pass over

```bash
   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust#48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`
```

Opt for the fully qualified syntax

Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@damip
Copy link
Member

damip commented Dec 30, 2021

@adrien-zinger this one can be solved now by cherrypicking

@AureliaDolo
Copy link
Contributor

@adrien-zinger this one can be solved now by cherrypicking

@damip has it been cherry picked ? Is someone working one that ?

@damip
Copy link
Member

damip commented Jan 3, 2022

bors merge

bors bot added a commit that referenced this pull request Jan 3, 2022
@bors @adrien-zinger
Merge #2046
f513973 
2046: Fix a compilation error (maybe temporary) r=damip a=adrien-zinger

It seems that we need to change something quick! The standard library will pass over

```bash
   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust#48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`
```

Opt for the fully qualified syntax

Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build failed:

@damip damip changed the base branch from main to feature/execution/add_cautious_bassoon January 3, 2022 11:40
@damip
Copy link
Member

damip commented Jan 3, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Canceled.

@damip
Copy link
Member

damip commented Jan 3, 2022

bors merge

bors bot added a commit that referenced this pull request Jan 3, 2022
@bors @adrien-zinger @damip
Merge #2046
a8f7b3c 
2046: Fix a compilation error (maybe temporary) r=damip a=adrien-zinger

It seems that we need to change something quick! The standard library will pass over

```bash
   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust#48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`
```

Opt for the fully qualified syntax

Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
Co-authored-by: damip <damipator@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build failed:

@damip
Copy link
Member

damip commented Jan 3, 2022

bors merge

bors bot added a commit that referenced this pull request Jan 3, 2022
@bors @adrien-zinger @damip
Merge #2046
e2f63ce 
2046: Fix a compilation error (maybe temporary) r=damip a=adrien-zinger

It seems that we need to change something quick! The standard library will pass over

```bash
   Compiling massa_consensus v0.1.0 (/home/adrien/Documents/repos/massa/massa-consensus)
warning: an associated function with this name may be added to the standard library in the future
   --> massa-consensus/src/pos.rs:522:37
    |
522 |         let bits_u8_len = n_entries.div_ceil(&u8::BITS) as usize;
    |                                     ^^^^^^^^
    |
    = note: `#[warn(unstable_name_collisions)]` on by default
    = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <rust-lang/rust#48919>
    = help: call with fully qualified syntax `num::Integer::div_ceil(...)` to keep using the current method
    = help: add `#![feature(int_roundings)]` to the crate attributes to enable `core::num::<impl u32>::div_ceil`
```

Opt for the fully qualified syntax

Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
Co-authored-by: damip <damipator@gmail.com>
@adrien-zinger
Copy link
Contributor Author

This is already merged in cautious bassoon. You can close this pr

@damip damip closed this Jan 3, 2022
@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Timed out.

@yvan-sraka yvan-sraka deleted the quick_fix/fix_compilation_error branch January 26, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

@gterzian gterzian gterzian left review comments

Assignees

@adrien-zinger adrien-zinger

Labels
None yet
Projects
None yet
Milestone
TEST.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien-zinger @damip @AureliaDolo @gterzian