Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gas price with fee #156

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Replace gas price with fee #156

merged 2 commits into from
Nov 16, 2022

Conversation

gterzian
Copy link
Contributor

No description provided.

@gterzian gterzian requested a review from aoudiamoncef October 24, 2022 08:08
@gterzian
Copy link
Contributor Author

gterzian commented Oct 24, 2022

@aoudiamoncef Ready for review.

Which branch did you mention I should target?

Where do I update the docs?

@aoudiamoncef
Copy link
Contributor

Which branch did you mention I should target?

create a new branch from : bugfix/op-wrong-types

Where do I update the docs?

update openrpc.json file which is located on the root of massa repository.

@gterzian
Copy link
Contributor Author

@aoudiamoncef Thanks for the info.

create a new branch from : bugfix/op-wrong-types

What do you mean? Is that the name of a branch I should branch off from(or target for merge)? I can't see it online actually, have you pushed it already?

@aoudiamoncef
Copy link
Contributor

It's here

IMHO, we could wait until merging this PR in main and back to update openrpc.json file.

@gterzian
Copy link
Contributor Author

gterzian commented Nov 2, 2022

IMHO, we could wait until merging this PR in main and back to update openrpc.json file.

@aoudiamoncef Since your PR has now merged, could you please tell me what I exactly should update?

@aoudiamoncef
Copy link
Contributor

aoudiamoncef commented Nov 2, 2022

Hi @gterzian

You have to update this JSON objects to match the current MassaAPI input/output

https://github.com/massalabs/massa/blob/mai(n/massa-node/base_config/openrpc.json#L1865-L1936

May be, we should rename the type to match exactly it's name in the Massa API.

@gterzian
Copy link
Contributor Author

gterzian commented Nov 4, 2022

@aoudiamoncef Ok I have updated the openrpc.json file in massalabs/massa#3173, should we try to merge this one after a review?

@gterzian
Copy link
Contributor Author

gterzian commented Nov 15, 2022

@aoudiamoncef What do you think is the right approach to merge this for provisional use in massalabs/massa#3181 (via massalabs/massa#3173), while preventing breakage for the hackaton? Use a new tag like 0.9? cc @damip

@aoudiamoncef
Copy link
Contributor

IMHO targeting testnet_17 is the solution to avoid breaking changes.

@damip
Copy link
Member

damip commented Nov 15, 2022

@aoudiamoncef What do you think is the right approach to merge this for provisional use in massalabs/massa#3181 (via massalabs/massa#3173), while preventing breakage for the hackaton? Use a new tag like 0.9? cc @damip

Those are breaking changes. We can't deliver them for the hackathon without breaking testnet16 and all the tooling around massa. So let's target testnet 17 => maybe create a testnet 17 branch here like we did for the massa repo, and make massa's testet17 branch depend on it

@gterzian gterzian changed the base branch from main to testnet_17 November 16, 2022 07:44
@gterzian
Copy link
Contributor Author

Ok, merging this one into a newly created testnet_17 branch...

@gterzian gterzian merged commit 6492862 into testnet_17 Nov 16, 2022
@bors bors bot deleted the replace_gas_price_with_fee branch November 16, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants