-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gas price with fee #156
Conversation
@aoudiamoncef Ready for review. Which branch did you mention I should target? Where do I update the docs? |
create a new branch from :
update |
@aoudiamoncef Thanks for the info.
What do you mean? Is that the name of a branch I should branch off from(or target for merge)? I can't see it online actually, have you pushed it already? |
It's here IMHO, we could wait until merging this PR in main and back to update |
@aoudiamoncef Since your PR has now merged, could you please tell me what I exactly should update? |
Hi @gterzian You have to update this JSON objects to match the current MassaAPI input/output https://github.com/massalabs/massa/blob/mai(n/massa-node/base_config/openrpc.json#L1865-L1936 May be, we should rename the type to match exactly it's name in the Massa API. |
@aoudiamoncef Ok I have updated the |
@aoudiamoncef What do you think is the right approach to merge this for provisional use in massalabs/massa#3181 (via massalabs/massa#3173), while preventing breakage for the hackaton? Use a new tag like |
IMHO targeting |
Those are breaking changes. We can't deliver them for the hackathon without breaking testnet16 and all the tooling around massa. So let's target testnet 17 => maybe create a testnet 17 branch here like we did for the massa repo, and make massa's testet17 branch depend on it |
Ok, merging this one into a newly created |
No description provided.