Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Search Not Working #38

Closed
3 tasks done
jonchen727 opened this issue Apr 16, 2022 · 10 comments
Closed
3 tasks done

[Bug]: Search Not Working #38

jonchen727 opened this issue Apr 16, 2022 · 10 comments

Comments

@jonchen727
Copy link

Describe the bug

Search does not after upgrading to 2.1.0.

To reproduce

  1. Enter anything into search

Version

2.1.0

OS

macOS

Validations

@heliomcp
Copy link

Related with my issue closed (#35).

@antonreshetov
Copy link
Member

Is there any sequence of actions leading to this bug? Because I can't reproduce this bug.

@github-actions
Copy link

Hello @jonchen727. Please describe in detail the sequence of actions that leads to the bug. Add screenshots of errors from the console. Issues marked with need reproduction will be closed if they have no activity within 3 days.

@lt-laurap
Copy link

Same problem here.
It's easier to notice when you try to search within a Folder, you will be redirected to the All Snippets section.

@antonreshetov
Copy link
Member

@lt-laurap redirecting to All Snippets during a search is normal behavior, because the search is performed on all snippets, not on a selected folder.

@jonchen727
Copy link
Author

jonchen727 commented Apr 19, 2022

Issue still present in v2.2.0
Steps to reproduce.

  1. Search for kubectl, results are returned do not have kubectl in the snippet.

image

Redid the search again and looks like kubectl highlights nordvpn and pretty much every 7 character combination

image

image

Some examples that are shorter work such as searching auth

image

@antonreshetov
Copy link
Member

antonreshetov commented Apr 19, 2022

@jonchen727 Still can't reproduce the bug. Maybe the db.json is corrupted?

Search is a very simple function:

search (query: string) {

Open db.json in the editor and look in this snippet in content[].value because according to the error in the console value is missing

@jonchen727
Copy link
Author

@antonreshetov
I found the issue, there was one snippet with a fragment with value null and the other fragment had a value. Now search works as intended, however there is another issue I saw.

When doing a search and the first fragment does not contain the search term, while the others do there, a weird highlighting occurs when you go into the fragment that contains the search term then to a different snippet, then back to the default fragment.

image

@antonreshetov
Copy link
Member

@jonchen727 That's a good thing. Then this Issue can be closed.

@heliomcp
Copy link

@antonreshetov I found the issue, there was one snippet with a fragment with value null and the other fragment had a value. Now search works as intended, however there is another issue I saw.

When doing a search and the first fragment does not contain the search term, while the others do there, a weird highlighting occurs when you go into the fragment that contains the search term then to a different snippet, then back to the default fragment.

image

Thank you, @jonchen727

@antonreshetov maybe there is something in database migration that is not working properly for this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants