Skip to content

Commit

Permalink
input-verify: add puppet verifier for puppetManifest input
Browse files Browse the repository at this point in the history
Units/parser-puppetManifest.r/puppet-append.d/verifier is very special.

About puppet-append.d/verifier, the puppet verifier reports this input as
"invalid" because `+=' operator is obsoleted in puppet5.
@ahakanbaba in universal-ctags#1909 reported and proposed a fix for this already.
However, @masatake kept this as is for following reasons:

  - valid in puppet4,
  - testing KNOWN-INVALIDATION special verifier, and
  - testing '#' comment in a verifier file.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
  • Loading branch information
masatake committed Oct 24, 2018
1 parent 2595f9f commit fdb705c
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 0 deletions.
12 changes: 12 additions & 0 deletions Units/parser-puppetManifest.r/puppet-append.d/verifier
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#
# The puppet verifier reports this input as "invalid" because
# += operator is obsoleted in puppet5.
# @ahakanbaba in #1909 reported and proposed a fix for this already.
#
# However, @masatake kept this as is for following reasons:
#
# - valid in puppet4,
# - testing KNOWN-INVALIDATION special verifier, and
# - testing '#' comment in a verifier file.
#
KNOWN-INVALIDATION
1 change: 1 addition & 0 deletions Units/parser-puppetManifest.r/verifier
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
puppet
32 changes: 32 additions & 0 deletions misc/verifiers/verifier-puppet
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# -*- sh -*-
# verifier-puppet - verifying puppetManifest input files
#
# Copyright (c) 2018, Hakan Baba
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
# USA.
#
action=$1
input=$2
case "$action" in
is_runnable)
type puppet > /dev/null 2>&1
exit $?
;;
verify)
puppet apply --noop "$input" > /dev/null
exit $?
;;
esac

0 comments on commit fdb705c

Please sign in to comment.