do not delete ubo when not using it

masahi · Apr 10, 2021 · 7cfea18 · 7cfea18
1 parent 23b1f40
commit 7cfea18
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/runtime/vulkan/vulkan.cc b/src/runtime/vulkan/vulkan.cc
@@ -828,10 +828,12 @@ class VulkanModuleNode final : public runtime::ModuleNode {
         vkDestroyDescriptorSetLayout(vctx.device, pe->descriptor_set_layout, nullptr);
         vkDestroyShaderModule(vctx.device, pe->shader, nullptr);
         // UBO
-        vkDestroyBuffer(vctx.device, pe->ubo.vk_buf->buffer, nullptr);
-        vkFreeMemory(vctx.device, pe->ubo.vk_buf->memory, nullptr);
-        delete pe->ubo.vk_buf;
-        delete[] pe->ubo.host_buf;
+        if (pe->ubo.host_buf) {
+          vkDestroyBuffer(vctx.device, pe->ubo.vk_buf->buffer, nullptr);
+          vkFreeMemory(vctx.device, pe->ubo.vk_buf->memory, nullptr);
+          delete pe->ubo.vk_buf;
+          delete[] pe->ubo.host_buf;
+        }
       }
     }
   }