Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol error handler #67

Merged
merged 5 commits into from
May 3, 2018
Merged

Protocol error handler #67

merged 5 commits into from
May 3, 2018

Conversation

oldfly
Copy link
Member

@oldfly oldfly commented Mar 28, 2018

Bug fix referring #66

Fixs in local file system, AWS S3 bucket, Hadoop file system.

For tests:

Run Pipeline action first, copy the result protocol, pass it wrong in Predictor Preparation action.
Engine executor should show error log with message like: "Invalid protocol: pipeline_336a66ca-4969-4e6e-a30d-b7756dd148d, reload action canceled!"

Pass the same protocol again correctly, and perform Predict action, the Predictor should be able to do your job instead of showing error message.

For AWS S3 test, set artifactManagerType in engine metadata to "S3", add s3BucketName key, and don't forget to set environment variables:
AWS_ACCESS_KEY_ID,
AWS_SECRET_ACCESS_KEY,
AWS_DEFAULT_REGION

For Hadoop test, set artifactManagerType to "HDFS", add hdfsHost key, and don't forget to set environment variables:
HADOOP_CONF_DIR

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #67 into master will decrease coverage by 1.72%.
The diff coverage is 24.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   79.72%   77.99%   -1.73%     
==========================================
  Files          22       22              
  Lines         651      668      +17     
  Branches       25       39      +14     
==========================================
+ Hits          519      521       +2     
- Misses        132      147      +15
Impacted Files Coverage Δ
...rg/marvin/artifact/manager/ArtifactHdfsSaver.scala 0% <0%> (ø) ⬆️
.../org/marvin/artifact/manager/ArtifactFSSaver.scala 8.69% <0%> (-2.42%) ⬇️
.../org/marvin/artifact/manager/ArtifactS3Saver.scala 77.41% <66.66%> (-10.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b29ed8...f352160. Read the comment docs.

@takabayashi takabayashi merged commit 25b9acd into master May 3, 2018
@oldfly oldfly deleted the zhg_protocol_validator branch June 29, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants