Use target fragments instead of tag lookups #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the sleep timer and multi-repeat value pickers would not work because they were unable to send values back to the calling fragment. This was failing because they were trying to look up a fragment with a specific tag, and the requesting fragment did not have a tag specified. Instead of adding a tag to the fragments, this commit fixes the issue by replacing the tag lookup with the built-in target fragment mechanism, which removes the requirement that fragments need to have a tag for the result to get delivered to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #164621769.
This fixes an issue where the sleep timer and multi-repeat value pickers would not work because they were unable to send values back to the calling fragment. This was failing because they were trying to look up a fragment with a specific tag, and the requesting fragment did not have a tag specified. This regression was probably introduced in 4c3985b.
Instead of adding a tag to the fragments, this commit fixes the issue by replacing the tag lookup with the built-in target fragment mechanism, which removes the requirement that fragments need to have a tag for the result to get delivered to them.
Testing Steps
Verify that the multi-repeat and sleep timer settings can be enabled from the now playing page. Only setting this preference is affected, the actual behavior of these options has not changed.