new refactor for the main CI/CD pipeline #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunusj
reviewed
Dec 23, 2024
app/utils/auth.py
Outdated
| # client = secretmanager.SecretManagerServiceClient(credentials=credentials) | ||
| # name = f"projects/{project_id}/secrets/{secret_id}/versions/{version_id}" | ||
| # response = client.access_secret_version(name=name) | ||
| # return response.payload.data.decode("UTF-8") |
There was a problem hiding this comment.
Remove this deadcode please.
AaronSosaRamos
added
the
maintainers only
|
@yunusj should i close this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the CI/CD pipeline by updating the
main.ymlfile for GitHub Actions to resolve the authentication issue with the API key in the production environment. The motivation behind this change is to ensure smooth deployment workflows and eliminate authentication-related failures during production builds.Related Issue
No issue is related with this PR.
Type of Change
Proposed Solution
The solution involved:
main.ymlfile in GitHub Actions to correctly handle environment secrets, specifically the API key.How to Test
Unit Tests
No unit tests were directly added or modified since this is a CI/CD pipeline change. Testing was performed through workflow execution.
Documentation Updates
If yes, describe what documentation updates are needed and link to the relevant documentation.
Checklist
Additional Information
This update resolves a critical issue affecting production deployments. The refactor ensures a smoother, more secure CI/CD process with properly handled secrets for authentication.