Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vendors overriding desktop rootfs img #13

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

pdsouza
Copy link
Member

@pdsouza pdsouza commented Apr 10, 2021

This commit allows vendors to override the default desktop rootfs image. To do this, we create a new module for rootfs.tar.gz and create a new variable TARGET_DESKTOP_ROOTFS that vendors can override to select a custom desktop rootfs image. If TARGET_DESKTOP_ROOTFS is not set, then we copy over our usual vendor/maruos/prebuilts/desktop-rootfs.tar.gz.

Also, if we ever integrate building the desktop rootfs directly into the Android build, this module would be a good place to call into our blueprints desktop building script.

Signed-off-by: Preetam D'Souza preetamjdsouza@gmail.com

Signed-off-by: Preetam D'Souza <preetamjdsouza@gmail.com>
@pdsouza
Copy link
Member Author

pdsouza commented Apr 10, 2021

Tested to make sure rootfs.tar.gz was copied over correctly with this new module and I am able to start the desktop fine.

Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdsouza
Copy link
Member Author

pdsouza commented Apr 10, 2021

Thanks for reviewing so quickly @utzcoz.

@pdsouza pdsouza merged commit 93f9e9a into maruos:maru-0.7 Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants