Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added away(msg, optional callback) + ignored rpl_luserunknown + emit 'unhandled' #80

Closed
wants to merge 4 commits into from

Conversation

alessioalex
Copy link

  1. Added (with doc & examples) away functionality:

bot.away('Leave a message', function(serverResponse) {
console.log('Server responds with..');
});

bot.away(); // remove away

  1. Added rpl_luserunknown to ignored

  2. Emit 'unhandled' event, just in case there's something missing (special) so you can handle it without changing the source code for node-irc.

@alessioalex
Copy link
Author

  1. On free node for example, when quitting you get this unhandled message:

Unhandled message: { command: 'ERROR',
rawCommand: 'ERROR',
commandType: 'normal',
args: [ 'Closing Link: 188.26.233.46 (Client Quit)' ] }

I've added code so this gets ignored.

@martynsmith
Copy link
Owner

Personally I'm okay with the creative hack to make the library play a little nicer with FreeNode. Sure, in a perfect world FreeNode wouldn't suck, but there's not much we can do about that.

Would it be possible to add the two nowaway and unaway events to the documentation too? (since people could subscribe to those independently of away's callback parameter?

@martynsmith
Copy link
Owner

Closing this due to lack of response ... If anyone feels strongly about it, feel free to re-open :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants