flood protection timeout configurable, another socket message to ignore for self signed certificates

[erikzaadi]

fixed self signed certificate problem, made floodProtection timeout configurable and put some more safeties around when joining an empty channel

[fent]

Nice. I was just about to do the configurable timeout on flood protection. Well, I wanted to rewrite most of the activateFloodProtection function because it uses a set interval to check if there is a new message to be sent in the queue every so often.

It was mentioned in the first flood protection pull request that this method might make a user's message be delayed by the amount of time the interval is set to. Node.js is also meant to be fully evented. It would be better to check if a message has been sent in the last timeout, if so, add to a message queue, if not, send the message and call setTimeout to call a function that looks at the queue and sends the oldest message queue'd.

[martynsmith]

Having a quick read through your patch there looks to be three things in there.

Two of them I believe are resolved with other pull requests, and so this doesn't cleanly merge anymore.

Are you able to re-do the pull request with just the flood protection timeout (and ideally a patch to the documentation too) then I can merge it :-)

[erikzaadi]

Sounds good, will do..

[lewinski]

I just attached a separate/documented version of the flood protection portions of this original pull request. Please let me know if anything needs rewording.

[martynsmith]

Hmmm, that looks good, I just need to work out how to merge it (since it's not its own pull request).

If I get around to it I'll sort it out, otherwise if you get a chance perhaps you could make a pull request with that commit in it?

[martynsmith]

This pull request has too many different things on it. The commit referenced by lewinski looks good, I'll pull that separately when I organise myself (or if he could make a new pull request even better) :-)