Detect and recover from ping timeouts #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
|
This looks great. I'll try and build a test for it, and work on getting it merged. |
|
Let me know if I can be of assistance! |
|
Looking forward to this! |
|
@philip-peterson if you could, rebasing this would make things a lot easier for me! |
|
rebase and squash ! :P |
philip-peterson
force-pushed
the
master
branch
from
9a177a5 to
c91436f
Compare
|
+1 |
jirwin
added a commit
that referenced
this pull request
Feb 15, 2016
Detect and recover from ping timeouts
|
Thanks! I'm planning on doing the next release in a week where this will land. |
|
Awesome! This has been a problem in teleirc, and we join in on eagerly awaiting the new release. 👍 |
This was referenced Mar 24, 2016
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-added support for ping timeout detection and recovery (relevant tickets: #76, #214, #176, #375). This has been tested by hand, but haven't been able to run it in a real environment (and won't, since my team no longer uses IRC), so beware there may yet be bugs.
I decided to err on the side of too "wordy" of code in order to allow easier testing later on and, hopefully, more readability. Feedback on how the code is structured and what could be done better/differently would be much appreciated.