fix(deps): Upgrade node-icu to 0.1.0 for v0.12 support. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #332 |
|
#328 can be also closed. |
|
Can this be merged and a patch version released? Node 0.12 is now upgraded in most distros and thus breaking this lib. |
|
I'd like to cut a new release this week. There are still some other issues preventing the lib from working on 0.12 that'll need to be handled. |
jirwin
added a commit
that referenced
this pull request
Mar 4, 2015
fix(deps): Upgrade node-icu to 0.1.0 for v0.12 support.
|
Any chance you could cut a release? Thanks! |
|
Ping. We still can't use this on node 0.12 until you publish a new version. Thanks! |
|
I'll cut a new release tomorrow! |
|
Awesome, thanks. |
|
@feross I've published version |
|
awesome, thanks! On Sat, Apr 25, 2015 at 2:02 PM Justin Gallardo notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.