Disconnect/Timeout handling and Input Validation

[Cari1111]

Issues

• resolves handle client disconnect #50
• resolves Write disconnected games in the game-database #65
• resolves Input Validation #21

Changes

Disconnect handling

When a player disconnects, all games that he currently participates in, are being forced to end. This means all players are notified that the game ended, and the game loop stops. Additionally the player that disconnected is saved in the game as self.disconnected_player_id.

Game Result

Every game has now scores that are stored as floats in the dictionary self.scores.
With that and the saved disconnected player, the result of the game can be created for every game in the same way. This is now done in IGame. The games are now all correctly written into the database.

Timeout handling

The Server has now a new method on_timeout(player, failure, timeout) which is called, when the connection of a player has a timeout. The player is then disconnected (with that e.g. games are handled).

Input Validation

The actions that are send are now validated by using the abstract method _validate_action(action). If an action is not valid, the player is disconnected.

Errbacks in the protocoll

All errors in the protocol are now handled in the handle_remote_error() method. This method is currently just printing a log message and I'm not sure what else to do, or if these messages are already too much, because the errors mostly occur when a player disconnects, and then they can be ignored.

This was solved in #90

[PacoSchatz]

Nice work. I didn't manage to produce an unhandled error if disconnecting various clients while several games are running.

Maybe you could think about renaming the force_end() or improving the docstring function in interfaces.py as I didn't immediately understand it's purpose. Otherwise its good! :)
Nice thx!