web: update home dashboard #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cari1111
requested review from
Raining-Cloud and
PacoSchatz
and removed request for
Raining-Cloud
PacoSchatz
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks for your work. It looks and works great. I tested it with a db of approx 1000 games and the information was displayed correctly.
I can't comment that much on code quality, as I am not as experienced in typescript, but I didn't spot any obvious flaws.
As a future task, it might be an option to count also draws, especially for the hockey game or similar games, as draws occur there often and are not the same as a loss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changes
sqlite.data.tsxand addedgetStatisticsfunction.DashboardPaperandDashboardsStatisticExample Images