Change rationale for manually looking for CcInfo #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to skip targets not providing CcInfo not just because of incompatible targets in old Bazel versions, but also due to bug: bazelbuild/bazel#19609 Given incompatible targets for aspects have been fixed in recent Bazel versions and the bug above has just been discovered, it makes no sense to keep mentioning incompatible targets as when above bug is fixed and we can remove this manual check for CcInfo incompatible targets are no longer relevant either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to skip targets not providing CcInfo not just because of incompatible targets in old Bazel versions, but also due to bug: bazelbuild/bazel#19609
Given incompatible targets for aspects have been fixed in recent Bazel versions and the bug above has just been discovered, it makes no sense to keep mentioning incompatible targets as when above bug is fixed and we can remove this manual check for CcInfo incompatible targets are no longer relevant either way.
Resolves: #33