Drop setup.{cfg,py} support, only support PEP-517 builds #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least in a local rpm mock build, the version is still broken. The included dbusmock/_version.py seems correct, though. |
|
Better, but still blocked on the too old version on centos 9 stream, which misses a line break. I'll try to remove the docstring and pacify it in pylint instead. |
|
Dang, the c9s build is still an empty rpm; reproducible locally with |
Merged
|
I broke out the preparation commits into #219, they are fine. |
Only support pyproject.toml and PEP-517 build tools (PyPA build). Move spec to PyPA build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now, I want to keep this open to track the packaging/distro bugs which prevent this.
With a simple
packit srpmandrpmbuild -rb python-dbusmock-0.28*.src.rpmin current Fedora 36 I get a broken rpm which only containsand no actual modules. It seems it does not read the metadata from pyproject.toml properly.