Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Clang builds on GitHub Actions #52

Merged

Conversation

striezel
Copy link
Contributor

A while ago the ubuntu-latest image of GitHub Actions moved from Ubuntu 22.04 to Ubuntu 24.04. See actions/runner-images#10636 for more information on that change.
However, Ubuntu 24.04 does not have packages for Clang 11 and 12 anymore, thus the Clang jobs failed when they tried to install the corresponding compilers. Therefore, the workflow is changed to use ubuntu-22.04 instead of ubuntu-latest.

Note: This could basically be a one line change, just changing runs-on: ubuntu-latest to runs-on: ubuntu-22.04. But if you want to run tests on newer Clang versions, too, then some of them might require Ubuntu 24.04, and in that case this form is easier to extend. For example, one could add the following lines to the job matrix to test more versions:

          - version: 13
            os: ubuntu-22.04
          - version: 14
            os: ubuntu-24.04
          - version: 16
            os: ubuntu-24.04
          - version: 18
            os: ubuntu-24.04

A while ago the 'ubuntu-latest' image moved from Ubuntu 22.04 to
Ubuntu 24.04. See <actions/runner-images#10636>.
However, Ubuntu 24.04 does not have packages for Clang 11 and 12
anymore, thus the Clang jobs failed when they tried to install
the corresponding compilers. Therefore, the workflow is changed
to use 'ubuntu-22.04' instead of 'ubuntu-latest'.
@striezel striezel force-pushed the fix-clang-builds-on-gha branch from 890e958 to 492f872 Compare January 25, 2025 01:48
@striezel
Copy link
Contributor Author

@martinmoene
The MSVC build on Windows 2022 is failing, but it's also failing on the current master (see https://github.com/martinmoene/variant-lite/actions/runs/13053386152/job/36418459317 for example), so that's nothing new and unrelated to the changes in this pull request.

@martinmoene martinmoene merged commit 7e3bce8 into martinmoene:master Jan 31, 2025
6 of 7 checks passed
@martinmoene
Copy link
Owner

@striezel thanks for answering my unquestioned question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants