-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inheriting constructors of isl::optional<T> results in a compilation error on gcc 6.4 and lower #55
Comments
@improbablejan, started working on it... |
martinmoene
added a commit
that referenced
this issue
Mar 5, 2020
…mprobablejan) Fixes implementation of optional_REQUIRES_T(), see martinmoene/nonstd-lite-project#40
martinmoene
added a commit
that referenced
this issue
Mar 5, 2020
…mprobablejan) Fixes implementation of optional_REQUIRES_T(), see martinmoene/nonstd-lite-project#40
martinmoene
added a commit
that referenced
this issue
Mar 5, 2020
…mprobablejan) Fixes implementation of optional_REQUIRES_T(), see martinmoene/nonstd-lite-project#40
martinmoene
added a commit
that referenced
this issue
Mar 5, 2020
…mprobablejan) Fixes implementation of optional_REQUIRES_T(), see martinmoene/nonstd-lite-project#40
martinmoene
added a commit
that referenced
this issue
Mar 5, 2020
…mprobablejan) Fixes implementation of optional_REQUIRES_T(), see martinmoene/nonstd-lite-project#40
martinmoene
added a commit
that referenced
this issue
Mar 5, 2020
…mprobablejan) (#57) Fixes implementation of optional_REQUIRES_T(), see martinmoene/nonstd-lite-project#40
@improbablejan, it looks like |
Thanks for the quick turnaround! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following code fails to compile on gcc versions 6.4 and lower:
while it appears to work with gcc version 7.1 and above. The compilation error produced (with
--std=c++14
GCC 6.4 on godbolt.org):@improbable-nickkrempel believes it could be due to the change in inheriting constructor semantics
which resolves issue 1941. Switching the SFINAE method used from a default argument to a default template type does seem to resolve the issue. Is there any reason why
optional_REQUIRES_A
is used when using SFINAE with constructors instead ofoptional_REQUIRES_T
, or could the method be switched in order to better support older GCC versions?The text was updated successfully, but these errors were encountered: