iter

martijnvg · Feb 6, 2025 · c6cc1e7 · c6cc1e7
1 parent 1d0a210
commit c6cc1e7
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/...er/src/main/java/org/elasticsearch/index/engine/LuceneSyntheticSourceChangesSnapshot.java b/...er/src/main/java/org/elasticsearch/index/engine/LuceneSyntheticSourceChangesSnapshot.java
@@ -194,14 +194,18 @@ private Translog.Operation[] loadDocuments(List<SearchRecord> documentRecords) t
                     maxDoc = leafReaderContext.reader().maxDoc();
                 } while (docRecord.docID() >= docBase + maxDoc);
 
+                // TODO: instead of building an array, let's just check whether doc ids are (semi) dense
                 IntArrayList nextDocIds = new IntArrayList();
                 for (int j = i; j < documentRecords.size(); j++) {
-                    int docID = documentRecords.get(j).docID();
-                    if (docBase + maxDoc >= docID) {
-                        break;
+                    var record = documentRecords.get(j);
+                    if (record.isTombstone()) {
+                        continue;
+                    }
+                    int docID = record.docID();
+                    if (docID >= docBase && docID < docBase + maxDoc) {
+                        int segmentDocID = docID - docBase;
+                        nextDocIds.add(segmentDocID);
                     }
-                    int segmentDocID = docID - docBase;
-                    nextDocIds.add(segmentDocID);
                 }
 
                 int[] nextDocIdArray = nextDocIds.toArray();