Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinGet Code Handling Modifications #3339

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mrixner
Copy link
Contributor

@mrixner mrixner commented Feb 21, 2025

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

Includes:

  • a random commit from last month that I forgot to PR that marks an uninstall that returns "no applicable version found" as successful (as in the user's eyes, it should be successful - unless you want this to mark an error condition?)
  • ignore the updates for a version if that program version has "no applicable update found" (note that this will likely eventually require a uninstall and reinstall of the program).

Should close #3326

{
return OperationVeredict.Failure;
}
if (uintCode == 0x8A15002B)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an update is not applicable, I think it is the choice of the user whether to hide the update or not. I don't think it is a good idea to automatically hide the package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll hide it behind a setting.

Copy link
Owner

@marticliment marticliment Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mrixner mrixner marked this pull request as draft February 26, 2025 19:05
@mrixner mrixner marked this pull request as ready for review March 1, 2025 23:40
@marticliment
Copy link
Owner

Tests are failing.

Also, when adding the package to ignored updates, I would return OperationStatus.Success, since, in this situation, the user has already told to UniGetUI to deal with this types of situations, so I don't think would be needed anymore to throw the eror, but then let the update disappear on the next reload..

@mrixner
Copy link
Contributor Author

mrixner commented Mar 2, 2025

Tests are failing.

Sorry, I made the update via GitHub UI and couldn't imagine how it wouldn't have worked, given that it was a very simple change to code that worked before - I forgot you updated the version system! (the merge broke the tests)

Also, when adding the package to ignored updates, I would return OperationStatus.Success, since, in this situation, the user has already told to UniGetUI to deal with this types of situations, so I don't think would be needed anymore to throw the eror, but then let the update disappear on the next reload..

👍🏻
I agree, it's much better to have this behind a setting.

@marticliment
Copy link
Owner

Great, I will test and merge as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants