-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinGet Code Handling Modifications #3339
base: main
Are you sure you want to change the base?
Conversation
src/UniGetUI.PackageEngine.Managers.WinGet/Helpers/WinGetPkgOperationHelper.cs
Outdated
Show resolved
Hide resolved
{ | ||
return OperationVeredict.Failure; | ||
} | ||
if (uintCode == 0x8A15002B) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an update is not applicable, I think it is the choice of the user whether to hide the update or not. I don't think it is a good idea to automatically hide the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll hide it behind a setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
…niGetUI into winget-code-correction
Tests are failing. Also, when adding the package to ignored updates, I would return |
Sorry, I made the update via GitHub UI and couldn't imagine how it wouldn't have worked, given that it was a very simple change to code that worked before - I forgot you updated the version system! (the merge broke the tests)
👍🏻 |
Great, I will test and merge as soon as I can |
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
Includes:
Should close #3326