Only Enumerate Existing Triplet Directories #3088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
If the vcpkg root was set to an empty directory (or rather a directory without a
triplets
directory inside it),Vcpkg.GetSystemTriplets()
would fail, as it would attempt to enumerate a directory that didn't exist, causing vcpkg source retrieval to not work and (the much bigger problem of) the settings page not loading. This pull request fixes that by only enumerating existing directories.I'm sorry; this was my bad. I assumed
Directory.EnumerateFiles()
would return an empty array if the directory didn't exist, not throw an error.related to #3085