Add support for perfect mensuration at simultaneous note levels #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emibreve, breve, longa, and maxima)
… on where the 'perfect' mensuration is
…t function Regarding the first point, the modification-related functions are the four mperfectionAPP, ImperfectionAPA, Alteration, and LeavePerfect, plus the functions that call them (FindDurQuals and EvalDotOfDiv). Regarding the second point, the GetValueUnit was dividing by one more level thant it should (as it was supposed to divide the middleSeq total by the smallerNoteLevel -not the boundUnit level)
…uality and effect of the dot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with
modusminor = 3andtempus = 3Tempus3Modus3.zip