Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: React 19 support #93

Closed
2 tasks done
mayocream opened this issue Nov 5, 2024 · 3 comments · Fixed by #94
Closed
2 tasks done

🚀 Feature: React 19 support #93

mayocream opened this issue Nov 5, 2024 · 3 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request

Comments

@mayocream
Copy link
Contributor

Bug Report Checklist

Overview

Support React 19, as well as Next.js 15 supported it.

Additional Info

No response

@marsidev marsidev self-assigned this Nov 7, 2024
@marsidev marsidev added the enhancement New feature or request label Nov 7, 2024
@joepetrillo
Copy link

@marsidev Any updates on this? Thanks!

@t6tv8e
Copy link

t6tv8e commented Nov 18, 2024

Not functional on Next.js 15?

@mayocream
Copy link
Contributor Author

Hi @marsidev, it functions on Next.js 15, but there's a warning that the peer dependency doesn't support React 19 RC.

❯ pnpm update --latest                                                                  (base) 
Packages: +2
++
Progress: resolved 589, reused 563, downloaded 2, added 2, done
 WARN  Issues with peer dependencies found
.
├─┬ @marsidev/react-turnstile 1.0.2
│ ├── ✕ unmet peer react@"^17.0.2 || ^18.0.0": found 19.0.0-rc-66855b96-20241106
│ └── ✕ unmet peer react-dom@"^17.0.2 || ^18.0.0": found 19.0.0-rc-66855b96-20241106

I think changing these two lines would support the React 19.

"react": "^17.0.2 || ^18.0.0",
"react-dom": "^17.0.2 || ^18.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants