-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Support for no_std #111
Conversation
This is great, thank you. A few thoughts:
|
alloc is only used when the std feature is deactivated and the alloc feature is. So 1.34.0 can still be the minimum version (but lower is also possible, we only use it for the byte reading stuff). For CI we can compile to thumbv6m-none-eabi, which doesn't have std. I'll look into making it compile to that. However we can't run the tests then. I'll put a section into the README. |
This adds the features `std` and `alloc` to the crate. The `std` feature is activated by default.
This should be good to go now. |
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=========================================
+ Coverage 95.88% 95.9% +0.02%
=========================================
Files 12 12
Lines 1457 1490 +33
=========================================
+ Hits 1397 1429 +32
- Misses 60 61 +1
Continue to review full report at Codecov.
|
Great, thank you! |
This adds the features
std
andalloc
to the crate. Thestd
feature is activated by default. This would bump the minimum supported version to 1.34.0, but only due to the byteorder removal (which apparently is also happening in #110).Supersedes #62