Switch to default OPLS atomtype names #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LigParGen assigns labels that are not used in the standard
/usr/local/gromacs/share/gromacs/top/oplsaa.ff/ffnonbonded.itpeven though it does not really create any new atom type that is not already listed in thatffnonbonded.itp(at least most of the times).This PR fixes this for PEO (currently the only OPLS polymer we have in the library; at least till I finish with #276): previously, the .ff files used the LigParGen-generated atom names; now they've been re-assigned to the standard OPLS atomtype names. This should make using the model easier, since one can now simply call the GMX default OPLS: