Fix settings_dict #257
Merged
Fix settings_dict #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
had a problem deploying
to
cloud-tests
GitHub Actions
Error
wanliAlex
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
papa99do
reviewed
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix
What is the current behavior? (You can also link to an open issue here)
if we provided
settings_dictwith other parameters when creating index, there is no error outWhat is the new behavior (if this is a feature change)?
We error out if settings_dict is provided with other parameters in create_index
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: