Multimodal model support #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
requested changes
Sep 9, 2024
| @@ -38,10 +38,13 @@ def test_simple_index_creation(self): | |||
| expected_settings = { | |||
There was a problem hiding this comment.
Can you have at least one test on the error message?
3 tasks
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
vicilliar
reviewed
Sep 10, 2024
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
previously approved these changes
Sep 11, 2024
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
wanliAlex
previously approved these changes
Sep 12, 2024
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
farshidz
reviewed
Sep 12, 2024
| "type": "structured", | ||
| "model": "LanguageBind/Video_V1.5_FT_Audio_FT_Image", | ||
| "inferenceType": "marqo.GPU", | ||
| "storageClass": "marqo.performance", |
There was a problem hiding this comment.
Why are we using performance?
There was a problem hiding this comment.
Thought it would be good for test coverage. I just switched to balanced
RaynorChavez
had a problem deploying
to
cloud-tests
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
farshidz
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
introduces new field for create index:
treat_urls_and_pointers_as_media(treat_urls_and_pointers_as_imagesis still supported). IntroducesaudioPreprocessingandvideoPreprocessingforstructuredandunstructuredindexes.What is the current behavior? (You can also link to an open issue here)
We only have
treat_urls_and_pointers_as_imagesand no index settings for audio and video preprocessing.What is the new behavior (if this is a feature change)?
In order to get marqo to download and process video and audio files from urls, we need
treat_urls_and_pointers_as_media. In fulfillment of marqo 2.12 PR Add multimodal model support marqo#931In order to allow the user to customize preprocessing fro audio and video files.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
TBD
Other information: